-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a breakdown of all packages in SS, not just the AIPs included in reports #47
Comments
This could also be framed as a report on what AIPScan includes in its database and what it doesn't. That's not just about errors (i.e. couldn't scan x AIPs) but also about helping users reconcile what is in AIPScan with what is in their storage system, including all packages, including DIPs, replicated AIPs, transfers, SIPs etc. |
I have got as far as cleaning up some of the METS work to make it easier to see where we need to log these issues. What I haven't figured out yet, is where to record them:
And we need to add a summary to the storage service view as well. I believe there are currently two places to log errors in processing (there might be a few others indicated by
|
Since this issue ticket was created, we've created several new issues to breakdown the error reporting requirement. To address Joel's feature suggestion (statistics for packages per SS), we've added the ability to record the number of SIPs, DIPs, replicated copies and deleted copies as columns in the Fetch Job table. See https://github.com/artefactual-labs/AIPscan/blob/main/AIPscan/Aggregator/tasks.py#L159-L179 However, we don't surface this information in the GUI for the user to see. I think the most natural place for this information is in the Fetch Job table that is shown at the bottom of a Storage Service page. This information could simply be read in from the table. However, if this information was to be provided as a report, or even for display on the SS page, it may be worthwhile to deliver it via an API. This would be in sync with the approach described in Issue #95. Therefore, the more elaborate/elegant way to deliver this feature is suggested in Issue #110 |
Love them both @peterVG. I like 2 most. How configurable is 2? Could it be a toggle, so click for the info and it displays. Click again and it disappears? |
Thanks @ross-spencer, me too, so I implemented a "hover" option in 'dev/package-stats-GUI' and submitted as PR. After fiddling with jQuery for a while I got stats display working when you hover the mouse over the Info icon. The stats are hidden again as soon as mouse moves away from the icon. |
@peterVG yep, it's looking good. Reason I ask about a toggle using a similar technique to the one you've adopted is that it might be nice to keep the information up on screen. Users might then toggle the information on between fetch jobs to compare without having to hover over and commit some of the info to memory. (I just generally like the idea of persisting information that is useful on screen but with the compromise here too that it doesn't by default use real-estate). What do you think? Is it at all feasible? |
Yeah, that's a good usability point. I'll try to implement that change and post an update here. |
I made the change from hover to click in the updated PR: #114 The behaviour now works as @ross-spencer suggested. Display on click for all info icons that are clicked. Hide the stats when the same info icon is clicked again. |
Include a log of the Exception errors that were reported for each.
Provide this count on the reports themselves?
The text was updated successfully, but these errors were encountered: