Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AttributeErrors when reading file properties to database more gracefully #83

Open
tw4l opened this issue Oct 21, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@tw4l
Copy link
Contributor

tw4l commented Oct 21, 2020

Currently if there is an attribute error at any point during the parsing of a file's properties from a METS FSEntry into the AIPscan database, the file gets written to the database as an ISO disk image, which is likely to be misleading:

except AttributeError:
# File error/warning to log. Obviously this format may
# be incorrect so it is our best guess.
file_info["file_format"] = "ISO Disk Image File"
file_info["puid"] = "fmt/468"
.

@ross-spencer
Copy link
Contributor

There is a nod to this particular issue here: #47 (comment) as I hoped to leave space for the developer working on #47 to consider this. So connected to #47, but a valid assertion. I should also have been clearer that the root cause of this is in metsrw archivematica/Issues#1277

@tw4l
Copy link
Contributor Author

tw4l commented Oct 22, 2020

Thanks @ross-spencer, I missed the connection to #47. That's good context!

@mcantelon mcantelon added the bug Something isn't working label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants