Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sortable size CSV field (#149) #261

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Add sortable size CSV field (#149) #261

merged 1 commit into from
Dec 6, 2023

Conversation

mcantelon
Copy link
Member

@mcantelon mcantelon commented Dec 2, 2023

Package and file size values in CSV exports were made to be human readable which was good for legibility, but impeded the ability to sort rows by size. Added automatic population of, whenever size data is included in an export, an additional column containing the "raw" byte value of a package or file size.

@mcantelon mcantelon force-pushed the dev/sortable-csv-v2 branch 28 times, most recently from eed2d6e to 694b02e Compare December 3, 2023 03:31
Copy link
Member

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcantelon
Copy link
Member Author

Thanks @sevein !

Package and file size values in CSV exports were made to be human readable
which was good for legibility, but impeded the ability to sort rows by size.
Added automatic population of, whenever size data is included in an export, an
additional column containing the "raw" byte value of a package or file size.
@mcantelon mcantelon force-pushed the dev/sortable-csv-v2 branch from 694b02e to 8287ebb Compare December 6, 2023 17:24
@mcantelon mcantelon merged commit 89d6466 into main Dec 6, 2023
6 checks passed
@mcantelon mcantelon deleted the dev/sortable-csv-v2 branch December 6, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants