Code cleanup/refactoring (#243) #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mcantelon
commented
Dec 5, 2023
•
mcantelon
commented
- Replaced use of api_url dict with StorageService instance or ID
- Did some refactoring to unify the AIP fetching code between the main app logic and the CLI tool
mcantelon
force-pushed
the
dev/unify-fetch-logic
branch
3 times, most recently
from
c1db8c0 to
1e8be56
Compare
mcantelon
force-pushed
the
dev/unify-fetch-logic
branch
8 times, most recently
from
8325adc to
1caf143
Compare
mcantelon
force-pushed
the
dev/unify-fetch-logic
branch
14 times, most recently
from
3741799 to
dfe49cb
Compare
mcantelon
force-pushed
the
dev/unify-fetch-logic
branch
10 times, most recently
from
564dd0e to
9d62ec5
Compare
mcantelon
force-pushed
the
dev/unify-fetch-logic
branch
10 times, most recently
from
a8b6293 to
59e7af8
Compare
* Replaced use of api_url dict with StorageService instance or ID * Did some refactoring to unify the AIP fetching code between the main app logic and the CLI tool
mcantelon
force-pushed
the
dev/unify-fetch-logic
branch
from
59e7af8 to
10d9287
Compare
sevein
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
I haven't tested but LGTM. I've noticed that the SS client logic coold be improved too, e.g. we're dealing with HTTP transport concerns in modules like database_helpers, etc. That could use some refactoring too in the future, e.g. a dedicated module with a Client or similar, something that could eventually be extracted into its own project if we wanted.
|
Thanks @sevein ! Yeah, agreed that further refactoring would definitely help. This is kind of a first pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.