Add AIPs search (#335) #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mcantelon
commented
Jul 3, 2024
•
mcantelon
commented
- Added text search to AIPs page
- Cleaned up AIP paging test
mcantelon
force-pushed
the
dev/aips-search
branch
4 times, most recently
from
fc15784 to
493d1a4
Compare
mcantelon
force-pushed
the
dev/aips-search
branch
2 times, most recently
from
f663885 to
3a802db
Compare
* Added text search to AIPs page * Cleaned up aip paging test
mcantelon
force-pushed
the
dev/aips-search
branch
from
3a802db to
a3c7549
Compare
sevein
approved these changes
Aug 8, 2024
Comment on lines
+111
to
115
| aips = aips.filter( | ||
| AIP.uuid.like(f"%{query}%") | ||
| | AIP.transfer_name.like(f"%{query}%") | ||
| | AIP.create_date.like(f"%{query}%") | ||
| ) |
There was a problem hiding this comment.
This guarantees a full table scan, it won't be very efficient. I guess that's ok for now?
There was a problem hiding this comment.
Yeah, this is just to get something in place to replace functionality that seemingly once existed (a client had made their own documentation of it with screenshots), yet weirdly doesn't seem to exist in the code (I scoured the commit history and could find any trade). Very weird!
If it's slow for them I might re-implement it with Typesense.
|
Thanks @sevein ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.