Fix ESLint for TypeScript projects (ext.webpack-eslint) (#579)

artembatura · Jun 2, 2020 · c64e845 · c64e845
1 parent 5cc3f57
commit c64e845
Show file tree

Hide file tree

Showing 5 changed files with 176 additions and 46 deletions.
diff --git a/package.json b/package.json
@@ -17,8 +17,8 @@
     "@types/get-port": "4.2.0",
     "@types/jest": "24.0.19",
     "@types/node": "12.11.2",
-    "@typescript-eslint/eslint-plugin": "2.5.0",
-    "@typescript-eslint/parser": "2.5.0",
+    "@typescript-eslint/eslint-plugin": "2.34.0",
+    "@typescript-eslint/parser": "2.34.0",
     "babel-eslint": "10.0.3",
     "eslint": "6.5.1",
     "eslint-config-prettier": "6.4.0",

diff --git a/packages/extension.webpack-eslint.react/package.json b/packages/extension.webpack-eslint.react/package.json
@@ -22,7 +22,7 @@
   "dependencies": {
     "@zero-scripts/core": "^0.4.0",
     "@zero-scripts/extension.webpack-eslint": "^0.4.0",
-    "eslint-config-react-app-fresh": "4.0.2",
+    "eslint-config-react-app": "5.2.1",
     "eslint-plugin-flowtype": "4.3.0",
     "eslint-plugin-jsx-a11y": "6.2.3",
     "eslint-plugin-react": "7.16.0",

diff --git a/packages/extension.webpack-eslint.react/src/WebpackEslintReactExtension.ts b/packages/extension.webpack-eslint.react/src/WebpackEslintReactExtension.ts
@@ -11,8 +11,7 @@ export class WebpackEslintReactExtension extends WebpackEslintExtension<
   WebpackEslintReactExtensionOptions
 > {
   public activate(preset: AbstractPreset): void {
-    // TODO: we can back to eslint-config-react-app, when it's released
-    this.optionsContainer.extends.push('eslint-config-react-app-fresh');
+    this.optionsContainer.extends.push('eslint-config-react-app');
 
     this.optionsContainer.parserOptions = {
       ...this.optionsContainer.parserOptions,

diff --git a/packages/extension.webpack-eslint/package.json b/packages/extension.webpack-eslint/package.json
@@ -20,10 +20,11 @@
     "build"
   ],
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "2.5.0",
+    "@typescript-eslint/eslint-plugin": "2.34.0",
+    "@typescript-eslint/parser": "2.34.0",
     "@zero-scripts/config.webpack": "^0.4.0",
     "@zero-scripts/core": "^0.4.0",
-    "babel-eslint": "10.0.3",
+    "babel-eslint": "10.1.0",
     "eslint": "6.5.1",
     "eslint-formatter-pretty": "2.1.1",
     "eslint-loader": "3.0.2",