Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build playground with stable Rust 1.37.0 #23

Merged
merged 5 commits into from
Oct 12, 2019
Merged

Build playground with stable Rust 1.37.0 #23

merged 5 commits into from
Oct 12, 2019

Conversation

lopopolo
Copy link
Member

Match toolchain specified in artichoke/artichoke.

@lopopolo lopopolo added A-build Area: CI build infrastructure. S-wip Status: This pull request is a work in progress. labels Sep 16, 2019
@lopopolo
Copy link
Member Author

Playground depends on the link_args feature to pass linker args to emscripten.

We might be able to set these using env variables in scripts/activate-wasm-build-env.sh.

This passes the emcc flags directly to rustc.
This reverts commit dd185cd.

    shared:ERROR: BINARYEN_TRAP_MODE is not supported by the LLVM wasm backend
@lopopolo
Copy link
Member Author

Tried to push the upgrade all the way to 1.38.0 but emcc fastcomp fails to link at Wasm load time and the upstream compiler fails to link at Rust compile time.

Watching this PR with interest: rust-lang/rust#65251

@lopopolo lopopolo added A-wasm-build-target Area: Support for wasm build targets. O-wasm-emscripten Target: Support for building the `wasm32-unknown-emscripten` target. labels Oct 12, 2019
@lopopolo lopopolo merged commit a9b72c0 into master Oct 12, 2019
@lopopolo lopopolo deleted the stable-rust branch October 12, 2019 22:14
@lopopolo lopopolo removed the S-wip Status: This pull request is a work in progress. label Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: CI build infrastructure. A-wasm-build-target Area: Support for wasm build targets. O-wasm-emscripten Target: Support for building the `wasm32-unknown-emscripten` target.
Development

Successfully merging this pull request may close these issues.

1 participant