Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error caused by connection error in socketio #158

Merged
merged 1 commit into from
Mar 30, 2017
Merged

fix error caused by connection error in socketio #158

merged 1 commit into from
Mar 30, 2017

Conversation

peara
Copy link
Contributor

@peara peara commented Mar 30, 2017

artilleryio/artillery#238

When SocketIo cannot connect because of high server load, ee.emit('started') won't be run.
This will lead to wrong count of scenarios ( negative number of scenarios ) and runner won't terminate.

@hassy
Copy link
Member

hassy commented Mar 30, 2017

Cheers @peara

@hassy hassy merged commit 75431a2 into artilleryio:master Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants