fix(validate-script): socketio runtime schema max value (#2151)

artilleryio · Sep 19, 2023 · 2c714fc · 2c714fc
1 parent 44b3aae
commit 2c714fc
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/examples/socket-io/app.js b/examples/socket-io/app.js
@@ -3,7 +3,9 @@ const io = require('socket.io')(8080, {
   serveClient: false
 });
 
-io.on('connection', (socket) => {
+const personalisedNamespace = io.of('/personalised');
+
+personalisedNamespace.on('connection', (socket) => {
   socket.on('echo', (msg) => {
     socket.emit('echoResponse', msg);
   });

diff --git a/examples/socket-io/socket-io.yml b/examples/socket-io/socket-io.yml
@@ -1,5 +1,5 @@
 config:
-  target: "http://localhost:8080/"
+  target: "http://localhost:8080"
   phases:
     - duration: 60
       arrivalRate: 25
@@ -8,7 +8,8 @@ scenarios:
   - name: "Emit and validate response"
     engine: socketio
     flow:
-      - emit:
+      - namespace: /personalised
+        emit:
           channel: "echo"
           data: "Hello from Artillery"
         response:
@@ -18,7 +19,8 @@ scenarios:
   - name: "Emit and validate acknowledgement"
     engine: socketio
     flow:
-      - emit:
+      - namespace: /personalised
+        emit:
           channel: "userDetails"
         acknowledge:
           match:

diff --git a/packages/artillery/lib/util/validate-script.js b/packages/artillery/lib/util/validate-script.js
@@ -83,7 +83,7 @@ const flowItemSchema = Joi.object({
   }),
   otherwise: Joi.when('...engine', {
     is: Joi.exist().valid('socketio'),
-    then: Joi.object().max(2),
+    then: Joi.object().max(3),
     otherwise: Joi.object().length(1)
   })
 });