Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(socketio): allow emit to be array of strings in validate-script #2167

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

bernardobridge
Copy link
Contributor

@bernardobridge bernardobridge commented Sep 26, 2023

Why

When running this valid Socketio interface (since this PR: #1112):

flow:
   - emit:
       - "join"
       - "lobby"

You would get this error Scenario validation error: "scenarios[0].flow[0].emit" must be of type object.

Testing

Tested with a scenario locally. Automated tests for this will be added as part of another PR, as I'm adding tests for socketio in artillery package soon (only exist in core, which makes things like this fall through the cracks).

@bernardobridge bernardobridge requested a review from a team September 26, 2023 10:36
@bernardobridge bernardobridge merged commit 4d965cb into main Sep 26, 2023
6 checks passed
@bernardobridge bernardobridge deleted the fix-validate-script branch September 26, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant