feat: warn when a Playwright test function can't be found #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HugoImaios
reviewed
May 28, 2024
| @@ -352,6 +352,14 @@ class PlaywrightEngine { | |||
| self.processor[spec.testFunction] || | |||
| self.processor[spec.flowFunction]; | |||
|
|
|||
| console.error('Playwright test function not found:', fn); | |||
There was a problem hiding this comment.
@hassy I might be wrong, but why is that console.error call not inside the if block below ?
There was a problem hiding this comment.
because since I updated to v2.0.13 I get spammed a lot about some test function not found 😄
There was a problem hiding this comment.
🤦♂️ and this is why even "trivial" changes should have an automated test. Will release a fix asap
There was a problem hiding this comment.
no problem, it didn't break anything, just printed a lot 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Print an error message when a Playwright test function can't be loaded. This can happen if a
testFunctionorflowFunctionattribute specifies a function that does not exist, or if the attribute is missing.Pre-merge checklist
This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.