fix(ArtistListItem): add accessibility props to the follow button #10703
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix accessibility issues of the follow button inside artist list card
|
Hi @yinuoyang01, first thanks for the contribution! Favor to ask, please don't delete the PR template, we rely on it for some automation on our end 🤖 I'll take the freedom to do it, but please remember to use it next time 😉 |
araujobarret
changed the title
araujobarret
reviewed
Sep 4, 2024
| <FollowButton haptic isFollowed={!!is_followed} onPress={handleFollowArtist} /> | ||
| <FollowButton haptic isFollowed={!!is_followed} onPress={handleFollowArtist} | ||
| accessibilityLabel={is_followed ? "Unfollow " + name : "Follow " + name} | ||
| accessibilityRole="button" /> |
There was a problem hiding this comment.
I think we should use role instead of accessibilityRole and for the label the RN community is moving towards aria props, so let's use aria-label instead 👍
gkartalis
reviewed
Sep 4, 2024
Comment on lines
+173
to
+174
| accessibilityLabel={is_followed ? "Unfollow " + name : "Follow " + name} | ||
| accessibilityRole="button" /> |
There was a problem hiding this comment.
Agree with @araujobarret, lets change that to what he suggested and ready to merge! Thanks for the contribution 😄
Suggested change
| accessibilityLabel={is_followed ? "Unfollow " + name : "Follow " + name} | |
| accessibilityRole="button" /> | |
| aria-label={is_followed ? "Unfollow " + name : "Follow " + name} | |
| role="button" | |
| /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix accessibility issues of the follow button inside artist list card
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.