-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support code injection !m! #1236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By analyzing the blame information on this pull request, we identified @ashfurrow to be a potential reviewer |
Generated by 🚫 danger |
This Danger fail is totally legit, however, I am very purposely editing this file. So we can consider it green. |
👍🎉😻 |
{ | ||
[self.rootNavigationController popViewControllerAnimated:NO]; | ||
[self runDeveloperExtras]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK - THIS IS AMAZING.
My compile & run cycle just went from (and I counted) 11 seconds to ~1 second.
Before we start, check out this GIF
What is happening?
Injection: Dynamically re-compiles files you've saved, and ships those changes to your currently running app.
How does this work? In simple, it is an Xcode plugin that can compile your code into a bundle, this bundle is then added to your app. It will include newer versions of the classes you've injected via this bundle, then it is up to you to do something with this.
What does this PR do? So, the default behaviour of Injection is to allows re-compiled classes to know that they have been re-compiled. Given the
viewDidLoad
heavy view controllers we create I felt it would be better for our flow to work a little different from that.Instead of letting the view controllers themselves act upon the injection, our top view controller is expanded to deal with the changes and adds some smart defaults. I've been recommending everyone use our developer extras to do their app cycle work: e,g,
I've expanded that to include a pop when injected, and to re-run the code inside developer extras. This means that the code inside
runDeveloperExtras
will be run on every injection. So you can keep working in the same file, constantly injecting new versions in again & again.