Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup of iOS intl polyfills #9202

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

gkartalis
Copy link
Member

@gkartalis gkartalis commented Aug 30, 2023

This PR resolves PHIRE-209

Description

As a follow up on the react native upgrade of @araujobarret we don't need anymore the polyfills that were added to ensure smooth hermes operation on iOS anymore.

In react native 70 they added the necessary polyfills (read more on the hermes issue here and in this blogpost)

The issue before was that anything date related wasn't working properly before like sorting articles or mycollection articles weren't displayed but confirmed that they work correctly.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

  • cleanup of iOS intl polyfills - gkartalis

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Copy link
Member

@MrSltun MrSltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹🧹🧹

@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • iOS user-facing changes (cleanup of iOS intl polyfills - gkartalis)

Generated by 🚫 dangerJS against a6cc1f1

@araujobarret
Copy link
Contributor

giphy720p.mp4

Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice ✨

@gkartalis gkartalis added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Aug 30, 2023
@artsy-peril artsy-peril bot merged commit aa15003 into main Aug 30, 2023
@artsy-peril artsy-peril bot deleted the gkartalis/remove-formatjs-polyfills branch August 30, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants