This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Update to React Native 0.56 RC #1117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
commented
Jun 25, 2018
| - SentryReactNative (= 0.30.3) | ||
| - yoga (= 0.54.4.React) | ||
| - SentryReactNative (= 0.38.0) | ||
| - yoga (= 0.55.4.React) |
There was a problem hiding this comment.
they don't bump the number until the release
and I updated sentry-reactnative also
| "tslint": "^5.8.0", | ||
| "tslint-config-prettier": "^1.6.0", | ||
| "typescript": "^2.5.3", | ||
| "typescript-styled-plugin": "^0.1.2" | ||
| "typescript": "2.6.2", |
There was a problem hiding this comment.
this is the specific version we were on, updating any further starts to break the types in RN and SC
| accessible={true} | ||
| hitSlop={undefined} | ||
| nativeID={undefined} | ||
| onLayout={undefined} | ||
| onResponderGrant={[Function]} |
There was a problem hiding this comment.
looks like snapshots just don't include this stuff now
| @@ -132,7 +125,7 @@ ShallowWrapper { | |||
| "behavior": "padding", | |||
| "children": Array [ | |||
| undefined, | |||
| <Styled(View) | |||
| <Styled(Component) | |||
There was a problem hiding this comment.
likely from the bump to SC-jest
| '../src/lib/Scenes/Favorites/__stories__/Favorites.story', | ||
| '../src/lib/Scenes/Home/Components/Sales/Components/__stories__/LotsByFollowedArtists.story', | ||
| '../src/lib/Scenes/Home/__stories__/Home.story', | ||
| '../src/lib/Scenes/Settings/__stories__/Settings.story', | ||
|
|
||
| ]; |
|
deprecated by #1210 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every page looks like I'd expect. This did note that we're getting really far behind WRT the react-native typings, it looks tricky to migrate those, so I made that a separate task from actually updating.