chore(i18n): Simplify how we work with i18n class components #10547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidimayra
added a commit
that referenced
this pull request
Jul 18, 2022
* feat: add i18next * Ensure json files are excluded in jest config This setting was leading our json files to be misinterpreted by the transpiler (build would fail trying to read json files as js files) * Try to remove the beginning of the regex on config * Test actual strings intead of keys * simplifying (#10547) * simplifying * chiller types Co-authored-by: araujobarret <araujobarret@gmail.com> Co-authored-by: Pavlos Vinieratos <pvinis@gmail.com>
damassi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Enhancement
Simplifying the way we use i18n-next on class components.