Fix artist.css 404 and inquire form css #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes longstanding 404 issue around
artist.css. File didn't exist inassetssince we build our css in a new way now in reaction via styled-components; however, our legacy pages expect an asset that matches the js file. This is no longer an issue in the new client-side-routing scheme of things.Also, fixes the unstyled inquire form on artist page in client-side routing context by importing legacy inquire form css (built with backbone) into the main layout css file.
This is the only old .js I believe we're using in our new pages, but for reference I moved the file import from here to here. If we ever encounter the need to access old js in new pages and that js has an associated stylesheet we'll need to do something similar.