Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redirects and links for Gallery Insights content #5082

Merged
merged 2 commits into from
Feb 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/desktop/apps/article/__tests__/routes.jest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { getCurrentUnixTimestamp } from "@artsy/reaction/dist/Components/Publish
import * as fixtures from "@artsy/reaction/dist/Components/Publishing/Fixtures/Articles"
import * as routes from "../routes"
import { extend } from "lodash"
import { GalleryInsightsRedirects } from "../gallery_insights_redirects"
const Article = require("desktop/models/article.coffee")
const Channel = require("desktop/models/channel.coffee")

Expand Down Expand Up @@ -173,6 +174,22 @@ describe("Article Routes", () => {
})
})

it("redirects to specific partners.artsy.net content if slug exists in redirect mapping", done => {
const slug = Object.keys(GalleryInsightsRedirects)[0]
const redirectSlug = GalleryInsightsRedirects[slug]

article.channel_id = "987"
article.slug = slug
positronql.mockReturnValue(Promise.resolve({ article }))

routes.index(req, res, next).then(() => {
expect(res.redirect).toBeCalledWith(
`https://partners.artsy.net/${redirectSlug}`
)
done()
})
})

describe("templates", () => {
it("sets the blank template for video layout", done => {
article = extend(fixtures.VideoArticle, {
Expand Down
30 changes: 30 additions & 0 deletions src/desktop/apps/article/gallery_insights_redirects.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
export const GalleryInsightsRedirects = {
"elena-soboleva-what-we-learned-from-writing-7-000-artist-bios":
"resource/what-we-learned-from-writing-artist-bios",

"gallery-insights-practical-digital-security-for-your-gallery":
"resource/digital-security-for-your-gallery",

"gallery-insights-brett-gorvy-new-storefont":
"resource/brett-gorvy-online-storefront",

"gallery-insights-the-pop-up-gallery-checklist?": "resource/pop-up-galleries",

"gallery-insights-artful-pitch": "resource/press-for-your-gallery",

"elena-soboleva-how-to-write-an-effective-press-release":
"resource/write-an-effective-press-release-for-your-gallery",

"gallery-insights-3-misconceptions-about-professional-art-buyers":
"resource/professional-art-buyers",

"gallery-insights-vr-galleries-04-04-17?": "resource/vr-for-galleries",

"gallery-insights-focus-in-on-better-gallery-photography":
"resource/focus-in-on-better-gallery-photography",

"elena-soboleva-sale-scam-verifying-online-inquiries":
"resource/verify-online-inquiries",

"gallery-insights-collectors-engaged": "resource/keep-collectors-engaged",
}
13 changes: 11 additions & 2 deletions src/desktop/apps/article/routes.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as _ from "underscore"
import embed from "particle"
import { URL } from "url"
import { URL, resolve } from "url"
import { App } from "desktop/apps/article/components/App"
import ArticleQuery from "desktop/apps/article/queries/article"
import {
Expand Down Expand Up @@ -28,6 +28,7 @@ import {
import cheerio from "cheerio"
import React from "react"
import { ArticleMeta } from "@artsy/reaction/dist/Components/Publishing/ArticleMeta"
import { GalleryInsightsRedirects } from "./gallery_insights_redirects"
const Articles = require("desktop/collections/articles.coffee")
const markdown = require("desktop/components/util/markdown.coffee")
const { crop, resize } = require("desktop/components/resizer/index.coffee")
Expand Down Expand Up @@ -61,7 +62,15 @@ export const index = async (req, res, next) => {
if (article.channel_id !== sd.ARTSY_EDITORIAL_CHANNEL) {
// Redirect deprecated Gallery Insights articles
if (article.channel_id === sd.GALLERY_INSIGHTS_CHANNEL) {
return res.redirect("https://partners.artsy.net")
const resourceSlug = GalleryInsightsRedirects[article.slug]

if (resourceSlug) {
return res.redirect(
resolve("https://partners.artsy.net", resourceSlug)
)
} else {
return res.redirect("https://partners.artsy.net")
}
}
return classic(req, res, next)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ block body
a.gallery-partnership-link.fine-faux-underline( data-context='galleries header' href='/#{type}-partnerships' )
| Partner with Artsy
if type === 'gallery'
a.fine-faux-underline( href='https://partners.artsy.net' )
a.fine-faux-underline( href='https://partners.artsy.net/gallery-resources' )
| Gallery Insights

block content
Expand Down