Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing ? from article redirect slug #5109

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Remove trailing ? from article redirect slug #5109

merged 1 commit into from
Feb 24, 2020

Conversation

dblandin
Copy link
Member

Missed this extra character in #5082. The redirect doesn't fire because the slug doesn't exactly match up with this character present.

Missed this extra character in #5082.
The redirect doesn't fire because the slug doesn't exactly match up with
this character present.
@dblandin dblandin self-assigned this Feb 24, 2020
@ArtsyOpenSource
Copy link

Warnings
⚠️ The staging version of Metaphysics has breaking changes, this might not affect your build, but could mean your queries don't work the way you expect. See below for breaking changes:
  • ⚠️ Type 'CreateSubmissionMutationInput' was removed
  • ⚠️ Type 'CreateSubmissionMutationPayload' was removed
  • ⚠️ Type 'UpdateSubmissionMutationInput' was removed
  • ⚠️ Type 'UpdateSubmissionMutationPayload' was removed
  • ⚠️ Type 'Asset' was removed
  • ⚠️ Field 'ConsignmentSubmissionConnection.edges' changed type from '[ConsignmentSubmissionEdge]' to '[SubmissionEdge]'
  • ⚠️ Field 'internalID' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'artistID' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'authenticityCertificate' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'dimensionsMetric' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'editionNumber' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'editionSize' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'locationCity' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'locationCountry' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'locationState' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'userID' was removed from object type 'ConsignmentSubmission'
  • ⚠️ Field 'ConsignmentSubmission.category' changed type from 'SubmissionCategoryAggregation' to 'ConsignmentSubmissionCategoryAggregation'
  • ⚠️ Field 'ConsignmentSubmission.edition' changed type from 'Boolean' to 'String'
  • ⚠️ Field 'ConsignmentSubmission.state' changed type from 'SubmissionStateAggregation' to 'ConsignmentSubmissionStateAggregation'
  • ⚠️ Field 'Mutation.createConsignmentSubmission' changed type from 'CreateSubmissionMutationPayload' to 'CreateConsignmentSubmissionPayload'
  • ⚠️ Type for argument 'input' on field 'Mutation.createConsignmentSubmission' changed from 'CreateSubmissionMutationInput!' to 'CreateConsignmentSubmissionInput'
  • ⚠️ Field 'Mutation.updateConsignmentSubmission' changed type from 'UpdateSubmissionMutationPayload' to 'UpdateConsignmentSubmissionPayload'
  • ⚠️ Type for argument 'input' on field 'Mutation.updateConsignmentSubmission' changed from 'UpdateSubmissionMutationInput!' to 'UpdateConsignmentSubmissionInput'
  • ⚠️ Type for argument 'input' on field 'Mutation.addAssetToConsignmentSubmission' changed from 'AddAssetToConsignmentSubmissionInput!' to 'AddAssetToConsignmentSubmissionInput'
  • ⚠️ Input field 'submission_id' was added to input object type 'AddAssetToConsignmentSubmissionInput'
  • ⚠️ Input field 'gemini_token' was added to input object type 'AddAssetToConsignmentSubmissionInput'
  • ⚠️ Input field 'assetType' was removed from input object type 'AddAssetToConsignmentSubmissionInput'
  • ⚠️ Input field 'geminiToken' was removed from input object type 'AddAssetToConsignmentSubmissionInput'
  • ⚠️ Input field 'submissionID' was removed from input object type 'AddAssetToConsignmentSubmissionInput'
  • ⚠️ Field 'AddAssetToConsignmentSubmissionPayload.asset' changed type from 'Asset' to 'ConsignmentSubmissionCategoryAsset'

Generated by 🚫 dangerJS against 8454be2

@artsy-peril artsy-peril bot merged commit ea13e54 into artsy:master Feb 24, 2020
@artsy-peril artsy-peril bot mentioned this pull request Feb 24, 2020
@dblandin dblandin deleted the update-gallery-insights-links-3 branch February 24, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants