Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect users to login on purchase routes #6759

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Redirect users to login on purchase routes #6759

merged 3 commits into from
Dec 10, 2020

Conversation

jpotts244
Copy link
Contributor

Co-authored-by: The-Beez-Kneez sutherlandanalisa@gmail.com

@The-Beez-Kneez The-Beez-Kneez changed the title WIP: Redirect users to login on purchase routes Redirect users to login on purchase routes Dec 7, 2020
@jpotts244
Copy link
Contributor Author

@The-Beez-Kneez congrats on your first PR! 🎉

Awesome work here and nice test case.

For tracking purposes, it might be nice to add a little description about the functionality you fixed in this PR and a link to the JIRA ticket! So we can use the PR as a little bit of documentation too!
Here's a nice example from our friend Matt in the Volt repo: https://github.com/artsy/volt/pull/4798

@The-Beez-Kneez
Copy link
Contributor

This PR introduces a redirect to the login page whenever a user navigates to the path /user/purchases and is not signed in.

Jira ticket: https://artsyproduct.atlassian.net/browse/PURCHASE-2213

@The-Beez-Kneez The-Beez-Kneez requested review from starsirius and mdole and removed request for erikdstock December 10, 2020 17:07
mdole
mdole approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@mdole mdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work

@The-Beez-Kneez
Copy link
Contributor

Merging this because @jpotts244 is out sick.

@The-Beez-Kneez The-Beez-Kneez merged commit ee505b5 into master Dec 10, 2020
@The-Beez-Kneez The-Beez-Kneez deleted the fix-500-err-for-logged-out-user-purchase branch December 10, 2020 22:44
@artsy-peril artsy-peril bot mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdole mdole mdole approved these changes

@starsirius starsirius Awaiting requested review from starsirius

Assignees

@jpotts244 jpotts244

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpotts244 @The-Beez-Kneez @mdole