Refactor consign pages to use artworksConnection and add realized / estimate price multiplier to /consign recently sold artworks #6775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and display realizedToEstimate value in rail
williardx
force-pushed
the
will/GRO-54
branch
from
9a4dbb0
to
e374a26
Compare
williardx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://artsyproduct.atlassian.net/browse/GRO-54
Related Metaphysics PR: artsy/metaphysics#2871
Problem
We want to show users the value of consigning on Artsy by showing positive outcomes for works sold on Artsy. To do this, we want to show the ratio of the realized price to the estimate for a work.
Solution
Add
realizedToEstimatefield on theArtworktype in Metaphysics and then display in Force.As part of this work we refactored the
ArtistTargetSupplyMicrofunneltype and related code in Metaphysics to only useartworksConnectioninstead of a separateartworksfield. This PR continues that refactor and converts existing views that rely onartworksto only useartworksConnection.Release strategy
This change is tightly coupled to changes in Metaphysics and will result in a small amount of downtime for consign pages while we roll out both services.
Screenshots