Backport NoSchemaIntrospectionCustomRule from graphql@15.2.0 #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyAghion
force-pushed
the
introspect
branch
from
11bcb57 to
1688b5e
Compare
|
Updated to require an MigrationWe plan to try this^ only in staging until we can surface and fix clients. |
dzucconi
reviewed
Sep 2, 2020
|
All this looks good to me |
This rule is adapted from graphql/graphql-js#2600 and should be replaced once using graphql >=15.2.0. Co-authored by: dzucconi <mail@damonzucconi.com>
joeyAghion
force-pushed
the
introspect
branch
from
1688b5e to
8da24c7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons described in PLATFORM-2793, it would be nice to be able to require authentication for introspection queries.
I tried to upgrade
graphqlto 15.2.0, which has a built-in rule added (graphql/graphql-js#2600), but encountered tons of failures. For now I'd be satisfied to adapt the rule to our codebase. The goal, ultimately, is for introspection to be enabled in development, but require an authorization header in staging/production.TODO:
Introspection shouldn't be possible locally in this version of the code, but for some reason still is.(This was caused by theENABLE_APOLLOflag beingtruelocally.)Improve typing of rule responses (currently(Fixed, at the expense of some slightly ugly array concatenation.)any).Maybe fix tests?(What tests? 😝 )