Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MyCollection] Trim sort options #2666

Merged
merged 1 commit into from
Sep 4, 2020
Merged

[MyCollection] Trim sort options #2666

merged 1 commit into from
Sep 4, 2020

Conversation

damassi
Copy link
Member

@damassi damassi commented Sep 3, 2020

Follow-up PR to https://github.com/artsy/gravity/pull/13439 which trims our sort options down to those attached to the CollectionArtwork vs Artwork:

  • position
  • created_at

@damassi damassi requested a review from a team September 3, 2020 23:44
@damassi damassi force-pushed the fix-mc-sort branch 2 times, most recently from 5946499 to 31d1610 Compare September 3, 2020 23:46
jonallured
jonallured approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@jonallured jonallured left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🎉

@ashleyjelks ashleyjelks merged commit 5506a3f into artsy:master Sep 4, 2020
@artsy-peril artsy-peril bot mentioned this pull request Sep 4, 2020
Merged
@damassi damassi deleted the fix-mc-sort branch September 4, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyjelks ashleyjelks ashleyjelks approved these changes

@jonallured jonallured jonallured approved these changes

Assignees

@ashleyjelks ashleyjelks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damassi @jonallured @ashleyjelks