-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FX-3300): return only running fairs #3412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this problem!
1b0fe1d
to
0e6977f
Compare
|
||
export const featuredFair = ( | ||
fairsLoader: LoadersWithoutAuthentication["fairsLoader"] | ||
) => { | ||
return fairsLoader({ | ||
size: 5, | ||
active: true, | ||
sort: "-start_at", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I believe the fairs API endpoint also supports a status
param which you might be able to use in order to filter down to running fairs without the explicit datetime comparison here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. The fair endpoint supports a status param. Thanks!
fc691c2
to
80ba6ee
Compare
80ba6ee
to
57b9463
Compare
The type of this PR is: Fix
Solves: FX-3300
Description
Demo
It's now September 13