Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix unhandled promise and the assertion. #930

Merged
merged 1 commit into from
Feb 16, 2018
Merged

[test] Fix unhandled promise and the assertion. #930

merged 1 commit into from
Feb 16, 2018

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Feb 16, 2018

@alloy
[test] Fix unhandled promise and the assertion.
e0239f3 
* Need to await
* Had to use this way to assert, as suggested here:
  jestjs/jest#3601 (comment)
@damassi
Copy link
Member

damassi commented Feb 16, 2018

👍

@damassi damassi merged commit 98de2fa into master Feb 16, 2018
@damassi damassi deleted the fix-unhandled-promise-in-tests branch February 16, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@damassi damassi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alloy @damassi