fix(packages/components): fix unit test (#260)

arup-group · Jun 4, 2024 · 74b44de · 74b44de
1 parent a847c15
commit 74b44de
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/components/src/components/accessibility/arc-accessibility.test.ts b/packages/components/src/components/accessibility/arc-accessibility.test.ts
@@ -322,7 +322,7 @@ describe('ArcAccessibility', () => {
   describe('events', () => {
     let element: ArcAccessibility;
     let themeRadioGroup: ArcRadioGroup;
-    const accessibilityChangeHandler: SinonSpy = sinon.spy();
+    let accessibilityChangeHandler: SinonSpy;
 
     /* Grab the user preferences from the localStore */
     const getCachedPreferences = () => {
@@ -336,6 +336,7 @@ describe('ArcAccessibility', () => {
     };
 
     beforeEach(async () => {
+      accessibilityChangeHandler = sinon.spy();
       element = await fixture(html`<arc-accessibility></arc-accessibility>`);
       themeRadioGroup = element.shadowRoot?.getElementById(
         'theme',

diff --git a/packages/components/src/components/table/arc-table.test.ts b/packages/components/src/components/table/arc-table.test.ts
@@ -134,7 +134,7 @@ describe('ArcTable', () => {
   /* Test specific methods */
   describe('methods', () => {
     let element: ArcTable;
-    const tableReadySpy: SinonSpy = sinon.spy();
+    let tableReadySpy: SinonSpy;
 
     /* Due to GridJS creating the table, the reference to any DOM elements is lost after each update. */
     const getTableBody = (): HTMLTableSectionElement => {
@@ -144,6 +144,7 @@ describe('ArcTable', () => {
     };
 
     beforeEach(async () => {
+      tableReadySpy = sinon.spy();
       element = await fixture(html`<arc-table></arc-table>`);
       element.addEventListener(ARC_EVENTS.tableReady, tableReadySpy);
     });
@@ -214,8 +215,7 @@ describe('ArcTable', () => {
         return columns[0] as HTMLTableCellElement;
       };
 
-      /* Wait for the underlying GridJS instance to finish rendering. */
-      await waitUntil(() => tableReadySpy.calledOnce, 'Table did not render');
+      await waitUntil(() => tableReadySpy.calledOnce);
 
       /* Update the GridJS configuration */
       element.updateConfig({
@@ -229,7 +229,7 @@ describe('ArcTable', () => {
       /* Wait for the underlying GridJS instance to finish rendering. */
       await waitUntil(
         () => tableReadySpy.calledTwice,
-        'Table did not update with date',
+        'Table did not update with data',
       );
 
       expect(firstColumn()).dom.to.equal('John');