Fix file format identifier for input files in setup instructions #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions ask the learner to create a file "chr1-star-index.yaml" that references an input file in the FASTA format, if they are to follow the steps for generating the STAR index themselves. In the YAML file however, the "format" field for that file referred to something else (FASTQ format). If the user followed the instructions and submitted the workflow to Arvados, the run would fail validation. Fixed by using the intended URI for the format (tested in Arvados 2.8.0 dev). Arvados-DCO-1.1-Signed-off-by: Zoë Ma <zoe.ma@curii.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions ask the learner to create a file "chr1-star-index.yaml" that references an input file in the FASTA format, if they are to follow the steps for generating the STAR index themselves.
In the YAML file however, the "format" field for that file referred to something else (FASTQ format). If the user followed the instructions and submitted the workflow to Arvados, the run would fail validation.
Fixed by using the intended URI for the format (tested in Arvados 2.8.0 dev).
Arvados-DCO-1.1-Signed-off-by: Zoë Ma zoe.ma@curii.com
Instructions
Thanks for contributing! ❤️
If this contribution is for instructor training, please email the link to this contribution to
checkout@carpentries.org so we can record your progress. You've completed your contribution
step for instructor checkout by submitting this contribution!
Keep in mind that lesson maintainers are volunteers and it may take them some time to
respond to your contribution. Although not all contributions can be incorporated into the lesson
materials, we appreciate your time and effort to improve the curriculum. If you have any questions
about the lesson maintenance process or would like to volunteer your time as a contribution
reviewer, please contact The Carpentries Team at team@carpentries.org.
You may delete these instructions from your comment.
- The Carpentries