Add energy plot #108
Open
Add energy plot #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 86.03% 85.28% -0.75%
==========================================
Files 24 25 +1
Lines 2843 2875 +32
==========================================
+ Hits 2446 2452 +6
- Misses 397 423 +26 ☔ View full report in Codecov by Sentry. |
OriolAbril
reviewed
Nov 19, 2024
| pc_kwargs=pc_kwargs, | ||
| ) | ||
|
|
||
| plot_collection.add_legend("energy", loc="outside right upper") |
There was a problem hiding this comment.
I opened an issue for this, it won't work across backends yet: #109
| return plot_collection | ||
|
|
||
|
|
||
| def _get_energy_ds(dt): |
There was a problem hiding this comment.
I'll try to look at https://docs.xarray.dev/en/stable/generated/xarray.DataArray.diff.html and see if we can make all this a bit more direct. I think it will also break when getting transposed inputs
There was a problem hiding this comment.
I have to admit, that I spent more than I expected to write this part (and try alternatives) :-)
aloctavodia
force-pushed
the
plot_energy
branch
from
581334d to
0fe58f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not working, because we have a
np.nanvalue📚 Documentation preview 📚: https://arviz-plots--108.org.readthedocs.build/en/108/