-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prior sense related functionality #24
Conversation
I have only looked at the Now both: import arviz_stats
from arviz_base import load_arviz_data, extract
idata = load_arviz_data("non_centered_eight")
arviz_stats.psens(idata, group="log_likelihood") and arviz_stats.psens(
idata.drop_nodes(["prior", "prior_predictive", "observed_data", "constant_data"]).stack(sample=["chain", "draw"]),
group="log_likelihood",
sample_dims="sample"
) work and return the same result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is nearly ready to merge, only some api and doc related points left
Closes #23
From the user perspective the main addition in this PR is the
psens_summary
function, which is equivalent to powerscale_sensitivity from the priorsense package.Where
sc
is a DataTree from a PyMC model equivalent tounivariate_normal
model in priorsense docs. Results are close to those, differences may be do to sampling differences, I need to check more carefully. There are also small differences compared to the result fromaz.psens
(now the samples are the same).📚 Documentation preview 📚: https://arviz-stats--24.org.readthedocs.build/en/24/