Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ecdf comparison plot #2178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Dec 2, 2022

Description

Aiming to add a new example of ecdf comparison but the band computation seems to have a bug.

Checklist

  • Does the PR follow official PR format?
  • Is the documentation numpydoc compliant?
  • Is the fix listed in the Documentation
    section of the changelog?

📚 Documentation preview 📚: https://arviz--2178.org.readthedocs.build/en/2178/

@aloctavodia
Copy link
Contributor

aloctavodia commented Dec 6, 2022

It seems to be a mistake with the computation of the band
mpl_plot_ecdf_comparison

@sethaxen
Copy link
Member

sethaxen commented Dec 6, 2022

IIRC, we merged this quickly from the GSOC work but didn't advertise it so that we could improve it before doing so. It also uses random sampling for the bands, which is quite slow, while the paper includes a deterministic approach for generating the bands.

@OriolAbril
Copy link
Member Author

do you remember the main issues @sethaxen ? If so, could you open an issue?

@sethaxen
Copy link
Member

sethaxen commented Dec 8, 2022

do you remember the main issues @sethaxen ? If so, could you open an issue?

No, I don't, I'm sorry. And looking back through Slack and GitHub, I'm not seeing the discussions that I thought I remembered.

I can open an issue about performance of the confidence band computation though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants