Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mad wrapper #4

Merged
merged 1 commit into from
Mar 13, 2022
Merged

add mad wrapper #4

merged 1 commit into from
Mar 13, 2022

Conversation

OriolAbril
Copy link
Member

Add a wrapper for the median_abs_deviation function in scipy.stats.

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #4 (679b723) into main (6b39cc7) will decrease coverage by 0.17%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   93.16%   92.99%   -0.18%     
==========================================
  Files           6        6              
  Lines         512      528      +16     
==========================================
+ Hits          477      491      +14     
- Misses         35       37       +2     
Impacted Files Coverage Δ
src/xarray_einstats/stats.py 92.04% <87.50%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b39cc7...679b723. Read the comment docs.

@OriolAbril OriolAbril merged commit 7787d1e into arviz-devs:main Mar 13, 2022
@OriolAbril OriolAbril deleted the mad branch March 13, 2022 19:05
@canyon289
Copy link
Member

Thanks :)

@OriolAbril
Copy link
Member Author

I will "need" this next week to test that arviz-devs/arviz#1974 correctly computes the mcse for the mad correctly. If there are summary stats or functions that are missing open an issue or send a PR.

logsumexp from scipy.special should probably be added for example. Note that most special functions don't need a wrapper though, they work on dataarrays straight away because they are pointwise: softmax, expit, logit... already work on xarray objects without any wrapper needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants