fix object cache key

asadowski10 · Oct 13, 2021 · f675c88 · f675c88
1 parent 961a1ee
commit f675c88
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## 3.1.5 - 13 Oct 2021
+- Fix object cache key with different $args for the same image and location
+
 ## 3.1.4 - 24 Sept 2021
 - Update `ari_responsive_image_caption` filter to add attachment id and attachment attributes params
 - Fix depecrated_function with check WordPress version

diff --git a/advanced-responsive-images.php b/advanced-responsive-images.php
@@ -1,7 +1,7 @@
 <?php
 /*
  Plugin Name: Advanced Responsive Images
- Version: 3.1.4
+ Version: 3.1.5
  Plugin URI: https://github.com/asadowski10/advanced-responsive-images
  Description: WordPress plugin to implement custom HTML markup for responsive images
  Author: Alexandre Sadowski
@@ -19,7 +19,7 @@
 }
 
 // Plugin constants
-define( 'ARI_VERSION', '3.1.4' );
+define( 'ARI_VERSION', '3.1.5' );
 define( 'ARI_MIN_PHP_VERSION', '5.4' );
 define( 'ARI_VIEWS_FOLDER_NAME', 'ari' );
 

diff --git a/classes/modes/picture-lazyload.php b/classes/modes/picture-lazyload.php
@@ -73,7 +73,8 @@ public function render_image( $html = '' ) {
 		}
 
 		$found = false;
-		$data  = wp_cache_get( $this->attachment_id . '-' . $this->args['data-location'], '', false, $found );
+		$key = md5( maybe_serialize( $this->args ) );
+		$data  = wp_cache_get( $this->attachment_id . '-' . $key, '', false, $found );
 		if ( ! empty( $found ) ) {
 			return $data;
 		}
@@ -149,7 +150,7 @@ public function render_image( $html = '' ) {
 
 		], $content_with_caption );
 
-		wp_cache_set( $this->attachment_id . '-' . $this->args['data-location'], $image, '' );
+		wp_cache_set( $this->attachment_id . '-' . $key, $image, '' );
 
 		return $image;
 	}