Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 202406072319 #19

Merged
merged 5 commits into from
Jun 8, 2024
Merged

Cherry pick 202406072319 #19

merged 5 commits into from
Jun 8, 2024

Conversation

nodece
Copy link
Collaborator

@nodece nodece commented Jun 7, 2024

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

tjiuming and others added 5 commits June 7, 2024 23:15
@tjiuming @nodece
[improve][broker] Add topic_load_failed metric (apache#19236)
1b75d97 
Co-authored-by: daojun <jmtao@streamnative.io>
(cherry picked from commit 43b3622)
@poorbarcode @nodece
[fix] [broker] Fix metrics pulsar_topic_load_failed_count is 0 when l…
9c345f1 
…oad non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed (apache#22580)

(cherry picked from commit 340d60d)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@shibd @nodece
[fix][schema] Error checking schema compatibility on a schema-less to…
4a2fb34 
…pic via REST API (apache#22720)

(cherry picked from commit 101aee4)
@shibd @nodece
Fix unit test for cherry-picked 573bf6d
bce9be0
@nodece
[fix][test] Fix testPerTopicStats (apache#22870)
73cf1d9 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece merged commit 73cf1d9 into branch-as-2.10 Jun 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodece @tjiuming @poorbarcode @shibd