Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #85 place footnotes at end of chapter (book) or document (article) #1016

Merged

Conversation

mojavelinux
Copy link
Member

  • place list of footnotes at end of chapter (when doctype is book) or document (when doctype is article)
  • add footnotes category to theme to style footnote list
  • add additional footnotes to example documents
  • honor footnotes-title attribute to control title of footnote list (unset by default)

@bcourtine
Copy link

I tested your PR and it looks good to me.

@bcourtine
Copy link

I thought of an evolution, but don't know how to implement it: if footnotes-title is defined, corresponding page could be added to the TOC (maybe with another option footnotes-toc).

@mojavelinux
Copy link
Member Author

I don't think that's the right use of a section heading. Footnotes are not a discrete section or appendix. They are an addendum to a section (chapter for book or document for article). Therefore, I conclude that they map closer to a block (as I have done it) than a section.

@bcourtine
Copy link

Seems legit with your enhancements. I was still thinking about my first version where all footnotes were in a unique end section (sometimes several pages long).

@mojavelinux
Copy link
Member Author

Indeed, if you have chapters, the footnotes should be broken up by chapter. They would only appear at the very end if you have no chapters or it's an article. This is consistent with how I've seen footnotes be handled in ebooks.

…ocument (article)

- place list of footnotes at end of chapter (when doctype is book) or document (when doctype is article)
- add footnotes category to theme to style footnote list
- add additional footnotes to example documents
- honor footnotes-title attribute to control title of footnote list (unset by default)
@mojavelinux mojavelinux merged commit f1410ff into asciidoctor:master Apr 13, 2019
@mojavelinux mojavelinux deleted the issue-85-footnotes-placement branch April 13, 2019 06:48
@gAmUssA
Copy link

gAmUssA commented Mar 4, 2020

@mojavelinux which version of asciidoctorj we have this feature?

@mojavelinux
Copy link
Member Author

mojavelinux commented Mar 4, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants