Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to define diagram images path for gitlab pages? #177

Closed
mingoal opened this issue May 19, 2018 · 1 comment
Closed

How to define diagram images path for gitlab pages? #177

mingoal opened this issue May 19, 2018 · 1 comment
Assignees
Milestone

Comments

@mingoal
Copy link

mingoal commented May 19, 2018

I tried to follow the REAMDE instruction to output PlantUML diagram. Didn't find the way to define correct output images path. Anybody knows how to do it?

Code @ https://gitlab.com/Mingoal/jekylldiagram
The output page is @
https://mingoal.gitlab.io/jekylldiagram/jekyll/update/2018/05/18/sample.html

In this page, the image path starts '/images/' instead of '/jekylldiagram/images/'. Which causes the image is not shown.

If you know how to correct it, please give me a tip. Thanks in advance.

mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue Nov 5, 2023
@mojavelinux
Copy link
Member

This is indeed a deficiency. The plugin should be prepending the baseurl to the value of the imagesdir attribute when the imagesdir value is root-relative. I've submitted a patch to address this.

@mojavelinux mojavelinux self-assigned this Nov 5, 2023
@mojavelinux mojavelinux added the bug label Nov 5, 2023
@mojavelinux mojavelinux added this to the v3.0.0 milestone Nov 5, 2023
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue Nov 5, 2023
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue Nov 5, 2023
@mojavelinux mojavelinux modified the milestones: v3.0.0, v3.0.x Nov 6, 2023
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue Nov 6, 2023
mojavelinux added a commit that referenced this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants