fix: Exit success when adding an already-added plugin

asdf-vm · Jul 18, 2023 · 47c7679 · 47c7679
1 parent d1a563d
commit 47c7679
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/functions/plugins.bash b/lib/functions/plugins.bash
@@ -79,8 +79,8 @@ plugin_add_command() {
   mkdir -p "$(asdf_data_dir)/plugins"
 
   if [ -d "$plugin_path" ]; then
-    display_error "Plugin named $plugin_name already added"
-    exit 2
+    printf '%s\n' "Plugin named $plugin_name already added"
+    exit 0
   else
     asdf_run_hook "pre_asdf_plugin_add" "$plugin_name"
     asdf_run_hook "pre_asdf_plugin_add_${plugin_name}"

diff --git a/test/plugin_add_command.bats b/test/plugin_add_command.bats
@@ -97,12 +97,12 @@ teardown() {
   [ "$output" = "dummy" ]
 }
 
-@test "plugin_add command with URL specified run twice returns error second time" {
+@test "plugin_add command with URL specified twice returns success on second time" {
   install_mock_plugin_repo "dummy"
 
   run asdf plugin add "dummy" "${BASE_DIR}/repo-dummy"
   run asdf plugin add "dummy" "${BASE_DIR}/repo-dummy"
-  [ "$status" -eq 2 ]
+  [ "$status" -eq 0 ]
   [ "$output" = "Plugin named dummy already added" ]
 }