fix(fish)!: don't resolve symlinks for ASDF_DIR #1583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the fish entry point, only make the ASDF_DIR path absolute, and don't resolve symlinks.
Other Information
Without this change, a
brew upgrade
causes all the shims to be broken.When asdf is installed by homebrew, it is placed in a versioned directory and then symlinked to
/usr/local/opt/asdf
. If the symlink is resolved, ASDF_DIR contains the versioned directory. This is a problem because shims use the value of ASDF_DIR to get an absolute path to the asdf executable.Not resolving symlinks is in line with the
asdf.sh
entry point.