Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(master): release 0.13.0 #1580

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 18, 2023

🤖 I have created a release beep boop

0.13.0 (2023-09-11)

⚠ BREAKING CHANGES

  • plugin list exit code 0 when no plugins are installed (#1597)
  • 0 exit code for success when adding an existing plugin (#1598)
  • fish: don't resolve symlinks for ASDF_DIR (#1583)

Features

  • add plugin location when update the plugin (#1602) (36c7024)

Patches

  • plugin list exit code 0 when no plugins are installed (#1597) (a029c00)
  • 0 exit code for success when adding an existing plugin (#1598) (4dd1904)
  • fish: don't resolve symlinks for ASDF_DIR (#1583) (d1a563d)
  • improve lint and test scripts (#1607) (b320803)
  • Make asdf.fish compatible with Fish 3.1.2 (#1590) (e83d71e)
  • no longer write temporary files to home directory (#1592) (624604a)
  • nushell language syntax update (#1624) (0ddab5d)
  • set default shell version values on POSIX entrypoint (#1594) (4d5f22d)
  • warn when any ./lib/commands are marked as executable (#1593) (2043a09)

Documentation

  • bin/latest-stable empty query is set to default (#1591) (299dc97)
  • migrate to VitePress from VuePress (#1578) (5133819)
  • upgrade deps & fix breaking changes (446f8c5)

This PR was generated with Release Please. See documentation.

@github-actions github-actions bot requested a review from a team as a code owner June 18, 2023 06:25
@jthegedus
Copy link
Contributor

jthegedus commented Jun 18, 2023

migrate to VitePress from VuePress (#1578) (5133819)

This change was the first to occur before any other changes after the last release. It caused Release Please to create a patch-level release. This was not expected. I think it is a bug in Release-Please.

{ "type": "docs", "section": "Documentation", "hidden": false }

Configuration to show docs: commits in the Changelog should not also make these commits get considered for version increments 🤔

Related googleapis/release-please#1745

@github-actions github-actions bot changed the title chore(master): release 0.12.1 chore(master): release 0.13.0 Jul 1, 2023
@github-actions github-actions bot force-pushed the release-please--branches--master branch from 954c807 to cb8285a Compare July 1, 2023 13:54
@hyperupcall
Copy link
Contributor

hyperupcall commented Jul 15, 2023

I was thinking the next release (bugfix release) could be done after the following are merged or resolved:

Thoughts?

I was hoping that the next version could have a version of 0.12.1 (IMO #1583 was a non-breaking-change patch). If it's easy to fix and there is agreement, then I think it would be nice to do. If not, then I don't really mind a full minor-version increment too-too much.

In the next feature release, I was hoping to implement #1579 (which is a breaking change) and #1599, which is why I wanted to get these bug fixes out of the way.

@hyperupcall
Copy link
Contributor

As a sort of side-note, I was wondering if asdf currently has a general stance on maintainership or if current maintainers were open to adding one?

I was thinking it would be quiet useful if I had the ability to add/remove tags from issues, enable running workflows, merge other people's PRs, etc. the usual stuff. I know ya'll maintainers are pretty busy, so I'm hoping the extra help could be useful. I've been contributing stuff for some time now, so I hope this ask isn't out of the blue or something. 😅

@hyperupcall
Copy link
Contributor

@jthegedus @Stratus3D I am sorry for pinging, but when one (or both) of you have the time, I would really appreciate a comment. Looking to get out a bugfix (and #1579) out sooner rather than later.

@github-actions github-actions bot force-pushed the release-please--branches--master branch from cb8285a to 8d49295 Compare July 26, 2023 11:42
@jthegedus
Copy link
Contributor

@hyperupcall Sorry mate, have been afk from OSS the past few weeks. Back at it though! I will review most of these over the coming days.

@github-actions github-actions bot force-pushed the release-please--branches--master branch 3 times, most recently from adc7653 to eaa336f Compare July 26, 2023 11:57
@hyperupcall
Copy link
Contributor

@jthegedus I understand, it can be difficult finding time for open source - you'll get to them when you get to them. If you feel comfortable adding me as a maintainer, I would be happy to help review others' PRs like I mentioned before. Also I know I'm a week late in responding and you are still busy, so I just wanted be explicit and say I'm not trying to be passive-aggressive with the timing of my response and everything I said was genuine.

@github-actions github-actions bot force-pushed the release-please--branches--master branch from eaa336f to c7c7603 Compare August 14, 2023 16:35
@github-actions github-actions bot force-pushed the release-please--branches--master branch 6 times, most recently from a6c3bb1 to 580b731 Compare September 11, 2023 11:03
@github-actions github-actions bot force-pushed the release-please--branches--master branch from 580b731 to d522c44 Compare September 11, 2023 13:44
@jthegedus
Copy link
Contributor

@jthegedus I understand, it can be difficult finding time for open source - you'll get to them when you get to them. If you feel comfortable adding me as a maintainer, I would be happy to help review others' PRs like I mentioned before. Also I know I'm a week late in responding and you are still busy, so I just wanted be explicit and say I'm not trying to be passive-aggressive with the timing of my response and everything I said was genuine.

Adding you as a maintainer is something I've been thinking about for some time and will definitely discuss with @Stratus3D about very soon.

Again, sorry for the delays here. Your help has been greatly appreciated as has your patience 😃

@jthegedus
Copy link
Contributor

Going to finally cut this release 😅

@jthegedus jthegedus merged commit 43ca61a into master Sep 11, 2023
@jthegedus jthegedus deleted the release-please--branches--master branch September 11, 2023 14:16
@github-actions
Copy link
Contributor Author

🤖 Release is at https://github.com/asdf-vm/asdf/releases/tag/v0.13.0 🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants