feat: Add versioning to plugin add command

[theoretick]

Summary

Allows user to specify version along with URL when adding plugin to lock
to a specific version instead of always relying on HEAD.

❯ git clone https://github.com/theoretick/asdf.git ~/.asdf --branch support-plugin-versions
Cloning into '/Users/theoretick/.asdf'...
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 5913 (delta 0), reused 1 (delta 0), pack-reused 5905
Receiving objects: 100% (5913/5913), 1.10 MiB | 12.68 MiB/s, done.
Resolving deltas: 100% (3400/3400), done.

❯ source ~/.asdf/asdf.sh

❯ asdf plugin add java https://github.com/halcyon/asdf-java.git

❯ asdf plugin add java https://github.com/halcyon/asdf-java.git travis-fix

❯ asdf plugin list
java
java-travis-fix

❯

Other Information

Relates to #234

[theoretick]

@jthegedus would you have a chance to look over this change soon or would there be another review I could pass this one to?

[theoretick]

@jthegedus sorry for the bump, would you be the best person to review this one or would there be another team member who could look over this change?

[jthegedus]

Sorry mate. I'll be reviewing this the next few days. Trying to get on top of the existing PRs so we can move forward on new changes at greater speed.

Appreciate the work you have contributed.

[jthegedus]

This is looking good so far.

I would like this change to also include what happens when asdf plugin update [<name> | --all] is called on a ref that is a tag. Currently it will ditch the tag and go back to the HEAD of the default branch.

Is that something you have time to look at @theoretick ?

[theoretick]

Is that something you have time to look at @theoretick ?

@jthegedus sorry for the delay but done with db90b80. I don't love the solution but please let me know what you think!

[theoretick]

This is looking good so far.

I would like this change to also include what happens when asdf plugin update [<name> | --all] is called on a ref that is a tag. Currently it will ditch the tag and go back to the HEAD of the default branch.

Is that something you have time to look at @theoretick ?

@jthegedus So I attempted this with 58de320 but it seems this approach is at odds with #800 given

asdf/test/plugin_update_command.bats

Line 59 in 95f2cdf

@test "asdf plugin-update should pull latest default branch (refs/remotes/origin/HEAD) for plugin even if already set to specific ref" {

explicitly updates detached HEADs to the default branch 🤔. I'm not sure how best to resolve this change in behavior. Do you have any suggestions?

[aabouzaid]

This feature is super crucial to have minimal security measurements.
Otherwise any plugin could be malformed and introduce a security breach.

[Stratus3D]

Hi @theoretick , sorry for the late reply here. I agree with @aabouzaid this feature is important for security reasons.

However, I'm in the process of rewriting asdf in Golang, and the rewrite should be done in a month or two. I don't see much point in getting this merged right now only to be replaced by the Golang implementation. Would you consider contributing these changes to the Golang implementation in a month or two?

[theoretick]

@Stratus3D sure, if I have capacity then I'd be happy to port it over and excited to see how the rewrite lands. Thanks!

[aabouzaid]

Just in case anyone is waiting for this, you can start using the community project ASDF Plugin Manager right away and control asdf plugins via .plugin-versions.