add BBC fork and update PR support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
byott
commented
May 2, 2024
byott
commented
- Add support for Update PR and Fork Repo in Bitbucket Cloud
- Add default reviewers when creating PR
- Note that Forking into a specific BBC project is not supported due to how the multi-gitter interfaces and parameters are set up.
gcase555
reviewed
May 3, 2024
| prOptions := &bitbucket.PullRequestsOptions{ | ||
| Owner: bbc.workspaces[0], |
There was a problem hiding this comment.
thanks for formatting this
gcase555
reviewed
May 3, 2024
| @@ -78,8 +87,34 @@ func (bbc *BitbucketCloud) CreatePullRequest(ctx context.Context, repo scm.Repos | |||
| } | |||
|
|
|||
| func (bbc *BitbucketCloud) UpdatePullRequest(ctx context.Context, repo scm.Repository, pullReq scm.PullRequest, updatedPR scm.NewPullRequest) (scm.PullRequest, error) { | |||
| //TODO implement me | |||
There was a problem hiding this comment.
I think this comment and panic have to go?
There was a problem hiding this comment.
It's removed on my side, is the diff showing up as included?
There was a problem hiding this comment.
Ah, on refresh I can see it, something was with my UI it seems like (it was showing as unchanged still), your good
ngandhi64
reviewed
May 3, 2024
| } | ||
| defaultReviewers, _ := bbc.bbClient.Repositories.Repository.ListDefaultReviewers(repoOptions) | ||
| for _, reviewer := range defaultReviewers.DefaultReviewers { | ||
| newPR.Reviewers = append(newPR.Reviewers, reviewer.Uuid) |
There was a problem hiding this comment.
Have you tried testing with no default reviewers on repo?
There was a problem hiding this comment.
Yup - I tried just tested it and confirmed it works. Tried create PR with no default reviewers, PR was created successfully with no reviewers on it
ngandhi64
approved these changes
May 3, 2024
gcase555
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.