Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create pr #6

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Fix create pr #6

merged 10 commits into from
Jun 24, 2024

Conversation

gcase555
Copy link
Collaborator

This PR does some more cleanup and adds the ID and guiurl to a newly created or updated PR. I needed to add some minimal JSON marshaling and unmarshaling to parse the ID and guiurl.

I removed unused files.

I also updated the documentation and commandline options to mention bitbucket cloud configuration options and moved our documentation to the correct template section.

@gcase555
Copy link
Collaborator Author

reviewers note: to be merged after the cleanup PR #5

@gcase555
Copy link
Collaborator Author

Now that we include the ID we can see it after creating a PR:
Megabees/kvstore-aws-accounts #140

Previously it would only show 0 and not the ID of the created PR.

@@ -132,3 +132,27 @@ All configuration in multi-gitter can be done through command line flags, config
{{end}}{{end}}

Do you have a nice script that might be useful to others? Please create a PR that adds it to the [examples folder](/examples).

## Bitbucket Cloud
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 💯

@gcase555 gcase555 requested a review from byott June 24, 2024 17:04
gcase555 added 2 commits June 24, 2024 12:15
@gcase555 gcase555 merged commit 2432aa3 into master Jun 24, 2024
@gcase555 gcase555 deleted the fix-create-pr branch June 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants