Allow later versions of s3fs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattp0
approved these changes
Oct 9, 2024
reweeden
force-pushed
the
rew/unpin-s3fs
branch
from
61344bf
to
0b540ec
Compare
mattp0
approved these changes
Oct 9, 2024
mckadesorensen
approved these changes
Oct 9, 2024
gjclark
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version we have pinned here is over 4 years old. Pinning it like this also causes issues with the https://github.com/ua-asf/Discovery-kerchunk-timeseries package which also requires s3fs.
Looks like later versions have an issue when used alongside
moto. There are some suggested hacks to make it work under this issue, however, I wasn't able to get them to work after a few hours of trying. Since we have a lot to do this sprint, I decided to just pin to version 0.4.2 of s3fs in our unit tests so that they continue to work while still allowing later versions to be installed.