ash-window: Require at least raw-window-handle 0.3.4 for 0.4 interop
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`raw-window-handle 0.3.4` was pushed as a "semver-trick-like" patch release, implementing the `0.3` trait for the `0.4` crate release [74]. This allows `ash-window` as a window-handle "consumer" crate to accept both `0.3` and `0.4` handles from consumer crates simultaneously. To ensure this patch release is available even when users omit regular `cargo update` or build with `-Z minimal-versions`, set the minimal patch version in `Cargo.toml` to it. [74]: rust-windowing/raw-window-handle#74
MarijnS95
added a commit
that referenced
this pull request
Jan 11, 2022
MarijnS95
added a commit
that referenced
this pull request
Jan 17, 2022
MarijnS95
added a commit
that referenced
this pull request
Jan 17, 2022
MarijnS95
added a commit
that referenced
this pull request
Jan 17, 2022
temportalflux
added a commit
to temportalflux/vulkan-rs
that referenced
this pull request
Apr 16, 2022
Supports both 0.3.x and 0.4.x in terms of the HasRawWindowHandle trait ash-rs/ash#553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raw-window-handle 0.3.4was pushed as a "semver-trick-like" patch release, implementing the0.3trait for the0.4crate release 74. This allowsash-windowas a window-handle "consumer" crate to accept both0.3and i0.4handles from consumer crates simultaneously. To ensure this patch release is available even when users omit regularcargo updateor build with-Z minimal-versions, set the minimal patch version inCargo.tomlto it.CC @dvc94ch, #505 (comment)