feat(node): upgraded to node v16 and all corresponding packages

BREAKING CHANGE: Running on v14 will most likely crash. Without v16 all Oyster commands will probably break fix #57
ashblue · Sep 19, 2022 · 68395a8 · 68395a8
1 parent 2dd1051
commit 68395a8
Show file tree

Hide file tree

Showing 16 changed files with 2,530 additions and 2,685 deletions.
diff --git a/.husky/commit-msg b/.husky/commit-msg
@@ -1,4 +1,4 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
 
-npx --no-install commitlint --edit 
+npx --no -- commitlint --edit
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-14.17.0
+16.17.0
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -24,8 +24,8 @@
   "author": "Ash Blue",
   "license": "MIT",
   "devDependencies": {
-    "@commitlint/cli": "^12.1.1",
-    "@commitlint/config-conventional": "^12.0.1",
+    "@commitlint/cli": "^17.1.2",
+    "@commitlint/config-conventional": "^17.1.0",
     "@semantic-release/changelog": "^5.0.1",
     "@semantic-release/commit-analyzer": "^8.0.1",
     "@semantic-release/git": "^9.0.0",
@@ -38,24 +38,23 @@
     "@types/jest": "^29.0.3",
     "@types/node": "^14.14.36",
     "@types/shelljs": "^0.8.8",
-    "@typescript-eslint/eslint-plugin": "^4.19.0",
-    "@typescript-eslint/parser": "^4.19.0",
-    "commitizen": "^4.2.3",
+    "@typescript-eslint/eslint-plugin": "^5.37.0",
+    "@typescript-eslint/parser": "^5.37.0",
+    "commitizen": "^4.2.5",
     "cz-conventional-changelog": "^3.3.0",
-    "eslint": "^7.23.0",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jest": "^24.3.6",
-    "eslint-plugin-jsdoc": "^32.3.0",
+    "eslint": "^8.23.1",
+    "eslint-plugin-import": "^2.26.0",
+    "eslint-plugin-jest": "^27.0.4",
+    "eslint-plugin-jsdoc": "^39.3.6",
     "eslint-plugin-node": "^11.1.0",
-    "husky": "^5.2.0",
+    "husky": "^8.0.1",
     "jest": "^29.0.3",
     "nodemon": "^2.0.7",
     "prettier": "~2.3.0",
     "pretty-quick": "^3.1.0",
     "semantic-release": "^17.4.2",
     "ts-jest": "^29.0.1",
-    "tslint": "^6.1.3",
-    "typescript": "^4.2.3"
+    "typescript": "^4.8.3"
   },
   "dependencies": {
     "chalk": "^4.1.0",

diff --git a/src/commands/install/command-install.ts b/src/commands/install/command-install.ts
@@ -34,6 +34,7 @@ export default class CommandInstall {
 
   private runPackageBuilder() {
     const terminal = new InstallQuestions(inquirer);
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     const gitDetector = new GitDetector(gitRemoteOriginUrl);
     const configManager = new ConfigManager();
     const packageBuilder = new PackageBuilder(

diff --git a/src/commands/install/git-detector/git-detector.spec.ts b/src/commands/install/git-detector/git-detector.spec.ts
@@ -7,6 +7,7 @@ describe('GitDetector', () => {
         .fn()
         .mockImplementation(() => Promise.resolve());
 
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       const gitDetector = new GitDetector(gitRemoteOriginUrl as any);
       const result = await gitDetector.checkIfGitRepo();
 
@@ -18,6 +19,7 @@ describe('GitDetector', () => {
         .fn()
         .mockImplementation(() => Promise.reject());
 
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       const gitDetector = new GitDetector(gitRemoteOriginUrl as any);
       const result = await gitDetector.checkIfGitRepo();
 
@@ -29,6 +31,7 @@ describe('GitDetector', () => {
         .fn()
         .mockImplementation(() => Promise.reject('a'));
 
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       const gitDetector = new GitDetector(gitRemoteOriginUrl as any);
       const result = await gitDetector.checkIfGitRepo();
 
@@ -46,6 +49,7 @@ describe('GitDetector', () => {
         .fn()
         .mockImplementation(() => Promise.resolve(remote));
 
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       const gitDetector = new GitDetector(gitRemoteOriginUrl as any);
       const details = await gitDetector.getDetails();
 
@@ -61,6 +65,7 @@ describe('GitDetector', () => {
         .fn()
         .mockImplementation(() => Promise.resolve(remote));
 
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       const gitDetector = new GitDetector(gitRemoteOriginUrl as any);
       const details = await gitDetector.getDetails();
 

diff --git a/src/commands/install/install-questions/install-questions.spec.ts b/src/commands/install/install-questions/install-questions.spec.ts
@@ -68,7 +68,7 @@ describe('InstallQuestions class', () => {
         await terminal.askName();
 
         const match = findQuestionMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _inquirerStub.prompt.mock.calls[0][0],
           'name',
           'input',
@@ -86,7 +86,7 @@ describe('InstallQuestions class', () => {
 
       it('should ask for the display name', () => {
         const match = findQuestionMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _inquirerStub.prompt.mock.calls[0][0],
           'displayName',
           'input',
@@ -97,7 +97,7 @@ describe('InstallQuestions class', () => {
 
       it('should ask for the description', () => {
         const match = findQuestionMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _inquirerStub.prompt.mock.calls[0][0],
           'description',
           'input',
@@ -108,7 +108,7 @@ describe('InstallQuestions class', () => {
 
       it('should ask for the unity version', () => {
         const match = findQuestionMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _inquirerStub.prompt.mock.calls[0][0],
           'unityVersion',
           'input',
@@ -119,7 +119,7 @@ describe('InstallQuestions class', () => {
 
       it('should ask for the author name', () => {
         const match = findQuestionMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _inquirerStub.prompt.mock.calls[0][0],
           'authorName',
           'input',
@@ -130,7 +130,7 @@ describe('InstallQuestions class', () => {
 
       it('should ask for the author email', () => {
         const match = findQuestionMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _inquirerStub.prompt.mock.calls[0][0],
           'authorEmail',
           'input',
@@ -141,7 +141,7 @@ describe('InstallQuestions class', () => {
 
       it('should ask for the author url', () => {
         const match = findQuestionMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _inquirerStub.prompt.mock.calls[0][0],
           'authorUrl',
           'input',
@@ -152,7 +152,7 @@ describe('InstallQuestions class', () => {
 
       it('should ask for keywords', () => {
         const match = findQuestionMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _inquirerStub.prompt.mock.calls[0][0],
           'keywords',
           'input',

diff --git a/src/commands/install/install-questions/install-questions.ts b/src/commands/install/install-questions/install-questions.ts
@@ -41,6 +41,7 @@ export default class InstallQuestions {
       this.questionKeywords(),
     ]);
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     answers.keywords = this.keywordsToJsonStringArray(answers.keywords);
 
     return answers as IQuestionsToAnswers;
@@ -65,6 +66,7 @@ export default class InstallQuestions {
       message: `Package name? Internal ID that's permanent. Example ${packageNameFormat} or ${packageNameExample}`,
       name: 'name',
       type: 'input',
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       validate: (value) => InstallQuestions.requiredString(value),
     };
   }
@@ -78,6 +80,7 @@ export default class InstallQuestions {
       message: `Package display name? Should be user-friendly. Example ${example} or ${exampleAlt}`,
       name: 'displayName',
       type: 'input',
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       validate: (value) => InstallQuestions.requiredString(value),
     };
   }

diff --git a/src/commands/install/package-builder/package-builder_config.spec.ts b/src/commands/install/package-builder/package-builder_config.spec.ts
@@ -72,8 +72,11 @@ describe('PackageBuilder class', () => {
       packageBuilder: new PackageBuilder(
         copyFolder,
         findPreExistingFiles,
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         installQuestions,
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         gitDetector,
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         config as any,
       ),
     };

diff --git a/src/commands/install/package-builder/package-builder_files.spec.ts b/src/commands/install/package-builder/package-builder_files.spec.ts
@@ -66,8 +66,11 @@ describe('PackageBuilder class', () => {
       _packageBuilder = new PackageBuilder(
         _copyFolder,
         _findPreExistingFiles,
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         _terminal,
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         _gitDetector,
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         { generate: jest.fn() } as any,
       );
     });
@@ -88,7 +91,7 @@ describe('PackageBuilder class', () => {
 
         it('should add a replace variable to copyFolder for packageScope', () => {
           const match = findVariableMatch(
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
             _copyFolder.mock.calls[0][2].replaceVariables,
             'packageScope',
             'com.a',
@@ -99,7 +102,7 @@ describe('PackageBuilder class', () => {
 
         it('should add a replace variable to copyFolder for .gitignore', () => {
           const match = findVariableMatch(
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
             _copyFolder.mock.calls[0][2].replaceVariables,
             'gitignore',
             '.gitignore',
@@ -110,7 +113,7 @@ describe('PackageBuilder class', () => {
 
         it('should add a replace variable to copyFolder for year', () => {
           const match = findVariableMatch(
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
             _copyFolder.mock.calls[0][2].replaceVariables,
             'year',
             new Date().getFullYear().toString(),
@@ -146,7 +149,7 @@ describe('PackageBuilder class', () => {
         await _packageBuilder.build(SOURCE, DESTINATION);
 
         const matchA = findVariableMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _copyFolder.mock.calls[0][2].replaceVariables,
           'packageName',
           name,
@@ -155,7 +158,7 @@ describe('PackageBuilder class', () => {
         expect(matchA).not.toBeUndefined();
 
         const matchB = findVariableMatch(
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
           _copyFolder.mock.calls[0][2].replaceVariables,
           replaceVariables[0].key,
           replaceVariables[0].value,
@@ -188,7 +191,7 @@ describe('PackageBuilder class', () => {
 
         replacements.forEach((replace) => {
           const match = findVariableMatch(
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
             _copyFolder.mock.calls[0][2].replaceVariables,
             replace.key,
             replace.value,

diff --git a/src/commands/shared/config/config.spec.ts b/src/commands/shared/config/config.spec.ts
@@ -25,7 +25,9 @@ describe('Config class', () => {
       ...options,
     };
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     jest.spyOn(path, 'resolve').mockReturnValue(packageJsonPath as any);
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     jest.spyOn(fs, 'readFileSync').mockReturnValue(packageJsonContents as any);
 
     return {

diff --git a/src/commands/shared/copy-folder/copy-folder__mocks.spec.ts b/src/commands/shared/copy-folder/copy-folder__mocks.spec.ts
@@ -34,6 +34,7 @@ describe('copyFolder helpers', () => {
       };
 
       jest.spyOn(glob, 'sync').mockReturnValue([]);
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       jest.spyOn(fs, 'statSync').mockReturnValue({
         isFile: () => isFile,
         isDirectory: () => !isFile,

diff --git a/src/commands/upgrade/command-upgrade.spec.ts b/src/commands/upgrade/command-upgrade.spec.ts
@@ -49,6 +49,7 @@ describe('CommandUpgrade class', () => {
       generate: jest.fn(),
     };
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     spySimpleGit.mockReturnValue({
       status: () => Promise.resolve({ isClean: () => !gitModifiedStatus }),
     } as any);

diff --git a/src/templates/.husky/commit-msg b/src/templates/.husky/commit-msg
@@ -1,4 +1,4 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
 
-npx --no-install commitlint --edit 
+npx --no -- commitlint --edit
diff --git a/src/templates/.nvmrc b/src/templates/.nvmrc
@@ -1 +1 @@
-14.16.0
+16.17.0
diff --git a/src/templates/{packageJson} b/src/templates/{packageJson}
@@ -31,18 +31,18 @@
   },
   "homepage": "{gitUrl}#readme",
   "devDependencies": {
-    "@commitlint/cli": "~12.0.1",
-    "@commitlint/config-conventional": "~12.0.1",
+    "@commitlint/cli": "^17.1.2",
+    "@commitlint/config-conventional": "^17.1.0",
     "@semantic-release/changelog": "~5.0.1",
     "@semantic-release/commit-analyzer": "~8.0.1",
     "@semantic-release/exec": "~5.0.0",
     "@semantic-release/git": "~9.0.0",
     "@semantic-release/github": "~7.2.0",
     "@semantic-release/npm": "~7.0.10",
     "@semantic-release/release-notes-generator": "~9.0.2",
-    "commitizen": "~4.2.3",
+    "commitizen": "^4.2.5",
     "cz-conventional-changelog": "~3.3.0",
-    "husky": "~5.1.3",
+    "husky": "^8.0.1",
     "semantic-release": "~17.4.2",
     "upm-package-populator": "^2.0.0"
   },