Skip to content

Minor changes

Minor changes #14

Triggered via push April 4, 2024 06:54
Status Success
Total duration 21s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/u512.rs#L1223
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/u512.rs:1223:1 | 1223 | impl Into<u8> for U512 { | ^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<u512::U512>` | 1223 ~ impl From<U512> for u8 { 1224 | #[inline] 1225 ~ fn from(val: U512) -> Self { 1226 ~ val.0[7] as u8 |
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/u512.rs#L1216
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/u512.rs:1216:1 | 1216 | impl Into<u16> for U512 { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<u512::U512>` | 1216 ~ impl From<U512> for u16 { 1217 | #[inline] 1218 ~ fn from(val: U512) -> Self { 1219 ~ val.0[7] as u16 |
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/u512.rs#L1209
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/u512.rs:1209:1 | 1209 | impl Into<u32> for U512 { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<u512::U512>` | 1209 ~ impl From<U512> for u32 { 1210 | #[inline] 1211 ~ fn from(val: U512) -> Self { 1212 ~ val.0[7] as u32 |
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/u512.rs#L1202
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/u512.rs:1202:1 | 1202 | impl Into<u64> for U512 { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<u512::U512>` | 1202 ~ impl From<U512> for u64 { 1203 | #[inline] 1204 ~ fn from(val: U512) -> Self { 1205 ~ val.0[7] |
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/u256.rs#L818
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/u256.rs:818:1 | 818 | impl Into<u8> for U256 { | ^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<u256::U256>` | 818 ~ impl From<U256> for u8 { 819 | #[inline] 820 ~ fn from(val: U256) -> Self { 821 ~ val.0[3] as u8 |
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/u256.rs#L811
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/u256.rs:811:1 | 811 | impl Into<u16> for U256 { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<u256::U256>` | 811 ~ impl From<U256> for u16 { 812 | #[inline] 813 ~ fn from(val: U256) -> Self { 814 ~ val.0[3] as u16 |
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/u256.rs#L804
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/u256.rs:804:1 | 804 | impl Into<u32> for U256 { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<u256::U256>` | 804 ~ impl From<U256> for u32 { 805 | #[inline] 806 ~ fn from(val: U256) -> Self { 807 ~ val.0[3] as u32 |
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/u256.rs#L797
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/u256.rs:797:1 | 797 | impl Into<u64> for U256 { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<u256::U256>` | 797 ~ impl From<U256> for u64 { 798 | #[inline] 799 ~ fn from(val: U256) -> Self { 800 ~ val.0[3] |
method `then_or` is never used: src/lib.rs#L5
warning: method `then_or` is never used --> src/lib.rs:5:8 | 4 | trait ThenOr { | ------ method in this trait 5 | fn then_or<T, B, Result>(self, fn1: T, fn2: B) -> Result | ^^^^^^^ | = note: `#[warn(dead_code)]` on by default
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/