Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to properly set arguments value #11

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Conversation

ashkan18
Copy link
Owner

@ashkan18 ashkan18 commented Oct 5, 2017

Problem

We need to properly set the arguments value when creating the query. Currently following code:

Graphlient::Query.new do
  invoices(id: 'test') do
    name
  end
end

results is

{
  invoices(id: test) {
    name
  }
}

Instead of id: "test"

Solution

Before setting the argument check the argument class and properly set it as argument value.

Gemfile.lock Outdated
@@ -1,7 +1,7 @@
PATH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemfile.lock should be deleted and added to .gitignore.

@dblock
Copy link
Collaborator

dblock commented Oct 5, 2017

Also needs changelog entry, please.

@dblock dblock closed this Oct 5, 2017
@dblock dblock reopened this Oct 5, 2017
@ashkan18
Copy link
Owner Author

ashkan18 commented Oct 5, 2017

Addressed those comments, going to merge 🙌

@ashkan18 ashkan18 merged commit f602331 into master Oct 5, 2017
@dblock
Copy link
Collaborator

dblock commented Oct 5, 2017

I cut 0.0.5 with this since it's a major fix.

@dblock dblock deleted the fix-argument-issue branch October 20, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants