Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Danger, PR linter. #21

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Oct 18, 2017

Already set the API token in Travis-CI. I'm using my own, but maybe @ashkan18 you can generate one for your own projects?

screen shot 2017-10-18 at 7 19 13 pm

Closes #6

@dblock
Copy link
Collaborator Author

dblock commented Oct 18, 2017

@orta is there a better way to do this now with Peril?

@ashkan18
Copy link
Owner

Looks good to me, I think we need to add this project to list of our repos under Peril, if we don't want to do that, I'll update the token later to use one of mines.

@ashkan18 ashkan18 merged commit 56ff3fb into ashkan18:master Oct 19, 2017
@dblock dblock deleted the danger-pr-linter branch October 19, 2017 15:11
@orta
Copy link
Contributor

orta commented Oct 19, 2017

Yeah, it'd require being in the Artsy org - so no to peril
This is optimal 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants