-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing queries from a String (in addition to a block) #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work.
This needs to be documented in README, please.
I also made some nitpicky comments on the specs. Would appreciate if these could be addressed, but not required.
Updated. What's the release schedule? Is this something that would be released in the next few days? Thanks. |
@ateamlunchbox thanks for you contribution, do you want to help co-maintain and make the next release following the RELEASING doc? otherwise i can do that later today 🙌 |
@ashkan18: Thanks for the invite. I'll hold off on becoming co-maintainer for now. If I end up making other contributions in the next couple months then I can sign on as a co-maintainer. |
Awesome! I'll cut a new release in few minutes and will let you know 🙌 |
|
Greetings. I've been using this library and it is very helpful.
I'd like to be able to parse a query from a String, not just a block.
Tests included.
Please let me know if this is acceptable.
Thanks.