Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing queries from a String (in addition to a block) #57

Merged
merged 6 commits into from
Jan 31, 2019

Conversation

ateamlunchbox
Copy link
Contributor

Greetings. I've been using this library and it is very helpful.

I'd like to be able to parse a query from a String, not just a block.

Tests included.

Please let me know if this is acceptable.

Thanks.

Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

This needs to be documented in README, please.

I also made some nitpicky comments on the specs. Would appreciate if these could be addressed, but not required.

spec/graphlient/static_client_query_spec.rb Outdated Show resolved Hide resolved
spec/graphlient/static_client_query_spec.rb Outdated Show resolved Hide resolved
@ateamlunchbox
Copy link
Contributor Author

Updated. What's the release schedule? Is this something that would be released in the next few days?

Thanks.

@ateamlunchbox ateamlunchbox reopened this Jan 31, 2019
@dblock dblock merged commit 1c02132 into ashkan18:master Jan 31, 2019
@ashkan18
Copy link
Owner

@ateamlunchbox thanks for you contribution, do you want to help co-maintain and make the next release following the RELEASING doc? otherwise i can do that later today 🙌

@ateamlunchbox
Copy link
Contributor Author

@ashkan18: Thanks for the invite. I'll hold off on becoming co-maintainer for now. If I end up making other contributions in the next couple months then I can sign on as a co-maintainer.

@ashkan18
Copy link
Owner

Awesome! I'll cut a new release in few minutes and will let you know 🙌

@ashkan18
Copy link
Owner

0.3.5 should be up now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants