Make graphlient run on Ruby 3.0 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ruby <= 2.4 is EOL - Ruby 3.0 is most recent ruby as of yesterday
GraphQL fixed a Ruby 3.0-issue in a more recent release, see: - rmosolgo/graphql-ruby@ec52695 - rmosolgo/graphql-ruby@0398808
It now says: Net::ReadTimeout with "Message"
Burgestrand
commented
Dec 25, 2020
| @@ -15,7 +15,7 @@ before_install: | |||
|
|
|||
| matrix: | |||
| include: | |||
| - rvm: 2.3.6 | |||
| - rvm: 2.7.2 | |||
There was a problem hiding this comment.
This could arguably be 3.0… but I'm not sure I wanted to risk it :D
Burgestrand
commented
Dec 25, 2020
| @@ -91,7 +91,7 @@ | |||
| expect do | |||
| client.execute(query, id: '42') | |||
| end.to raise_error Graphlient::Errors::GraphQLError do |e| | |||
| expect(e.to_s).to eq 'Variable id of type Int was provided invalid value' | |||
| expect(e.to_s).to eq 'Variable $id of type Int was provided invalid value' | |||
There was a problem hiding this comment.
This is due to allowing a newer graphql version, which was required for Ruby 3.0-compatibility.
Burgestrand
commented
Dec 25, 2020
| AllCops: | ||
| TargetRubyVersion: 2.3 | ||
|
|
||
| Lint/SplatKeywordArguments: |
There was a problem hiding this comment.
This is an old cop that has long since been removed.
Burgestrand
commented
Dec 25, 2020
| @@ -1,3 +1,9 @@ | |||
| AllCops: | |||
| TargetRubyVersion: 2.3 | |||
There was a problem hiding this comment.
We could definitely use a newer version here (this used to be picked up from .ruby-version), but that generated new cop warnings so I decided against it.
|
👍 |
|
Just cut a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon trying graphlient on Ruby 3.0 I noticed a few issues, one of them being critical: effbf5d
All the other commits were made to get either CI to pass, tests to pass, or rubocop to pass. 😄