chore: replace Travis CI with Github Actions #89
Conversation
Otherwise, it's broken when running on Github Actions
This commit adds GHA files for CI, Danger, and Rubocop and removes travis configurations. Note: Ruby 2.5.0 is broken with specs. Consider to drop its support since it's already EOL.
QQism
changed the title
| - 2.7.2 | ||
| - 3.0.0 | ||
| - ruby-head | ||
| - jruby-9.1.17 |
There was a problem hiding this comment.
Have to pump this to jruby-9.1.17 since ubuntu-latest doesn't have jruby-9.1.16.0. See this
QQism
changed the title
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| continue-on-error: ${{ contains(fromJSON('["2.5.0", "ruby-head", "jruby-9.1", "jruby-head"]'), matrix.ruby-version) }} |
There was a problem hiding this comment.
I would just set this to true/false
There was a problem hiding this comment.
Yeah, that would be much simpler. I wanted to stay close to the old travis.yml as much as possible i.e. ruby-head, jruby-9.1 and jruby-head are optional steps.
| danger_file: 'Dangerfile' | ||
| danger_id: 'danger-pr' | ||
| env: | ||
| DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
I don't think this will work, I had to do something like https://github.com/dblock/strava-ruby-client/blob/0d7f31cf1f839d9a7a727832e182d8fb8c47d6cc/.github/workflows/danger.yml
There was a problem hiding this comment.
Thanks, turned out it only worked in my fork but not in this main repository. I've just updated with your example. Can you please have a look here?
|
Thank you! Make another PR that drops Ruby 2.5.0, and checks Danger? |
By default, `GITHUB_TOKEN` from a fork repository doesn't have write permission to the current pull request, so we have to use a personal token. See: ashkan18#89 (comment)
By default, `GITHUB_TOKEN` from a fork repository doesn't have write permission to the current pull request, so we have to use a personal token. See: ashkan18#89 (comment)
By default, `GITHUB_TOKEN` from a fork repository doesn't have write permission to the current pull request, so we have to use a personal token. See: ashkan18#89 (comment)
This commit adds GHA files for CI, Danger, and Rubocop and removes
travis configurations.
Note: Ruby 2.5.0 is broken with specs. Consider to drop its support
since it's already EOL.
It seems working fine here QQism#1